Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the flag enable-protocol-upgrade-via-soroban-env-host-prev set by default #4357

Closed
anupsdf opened this issue Jun 18, 2024 · 3 comments
Closed
Assignees

Comments

@anupsdf
Copy link
Contributor

anupsdf commented Jun 18, 2024

What:

Have the flag enable-protocol-upgrade-via-soroban-env-host-prev set by default. Introduce a new flag to exclude prev so it can be used for minor releases after the protocol upgrade.

Why:

Nodes without the prev host will reject protocol upgrades during consensus. During protocol 21 upgrade we saw a validator had built core from source and missed setting this flag. This caused them to loose sync during the upgrade.

@sisuresh
Copy link
Contributor

I wonder if we should just remove the flag and always have prev enabled. @graydon Is there any benefit to removing the prev crate other than slightly reducing the binary size?

@graydon
Copy link
Contributor

graydon commented Jun 18, 2024

Nothing comes to mind, I'd certainly be willing to try it and see if anything goes wrong.

@sisuresh
Copy link
Contributor

Closed by #4434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment