Skip to content

[bug] 重复代码(normalizeArgs / safeParse) #95

Description

@Misaka477

step-realtime-cli 版本

1.0.0

Node 版本 & OS

Node 24.16.0 / Linux (Fedora 44)

复现步骤

grep -n "normalizeArgsForFingerprint\|normalizeToolArguments" \
  packages/core/src/agent/agent-loop.ts packages/core/src/tools/runtime.ts
grep -n "function safeParse" \
  packages/core/src/tools/native-impls/shell-tools.ts packages/core/src/tools/native-impls/file-tools.ts

期望行为

公共函数应提取到 packages/utils 共享层,消除重复维护

实际行为

两处完全相同的代码重复:

  1. normalizeToolArgumentsnormalizeArgsForFingerprint — JSON 序列化+折叠逻辑在 agent-loop.tsruntime.ts 中各有一份
  2. safeParse(JSON.parse 包装函数)在 shell-tools.tsfile-tools.ts 中各有一份

日志 / 堆栈

截图(可选)

No response

自检

  • 我已搜索 existing issues,确认这不是重复问题
  • 我已阅读 CONTRIBUTING.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions