Skip to content

PR-255.md

Latest commit

 

History

History
37 lines (26 loc) · 1.14 KB

PR-255.md

File metadata and controls

37 lines (26 loc) · 1.14 KB
Raw

PR 255: fix(logging): bound log-record XPC responses

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Motivation and Context

Closes #254. Log-record requests previously bypassed the Container API client's bounded XPC helper. A registered but non-responsive API server could therefore hang a caller indefinitely.

Implementation

  • Expose optional response timeouts on log-record retrieval, follow, file, and decoded-stream APIs.
  • Preserve the existing 60-second registration timeout as the default.
  • Route request setup through the existing cancellation-aware XPC timeout implementation.
  • Add source-level tests for the new bounded call forms.

Testing

  • Tested locally
  • Added/updated tests
  • Added/updated docs

Validated with swift test --filter ContainerClientLoggingRequestTests and the formatting portion of make check.

Compatibility and Risk

Existing calls remain source compatible. Callers that need a shorter operational bound can now select one without implementing an unsafe external timeout race. The change is isolated to enhanced log-record client requests.