Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kdo pod is deleted even if client process is killed #25

Open
stepro opened this issue Jun 5, 2020 · 0 comments
Open

Ensure kdo pod is deleted even if client process is killed #25

stepro opened this issue Jun 5, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@stepro
Copy link
Owner

stepro commented Jun 5, 2020

Right now, if the client process dies, it doesn't send the delete pod request to the server. In some cases, if the client's stdin is connected to the command and that stream ends, the command ends and the right thing happens. But this isn't the case for other commands.

The best approach here would be for all (non-detached) kdo pods to run a kdo sidecar that listens on stdin until that stream is closed, and then to clean things up on the server side. On the client, a kubectl attach can be used to connect to that stream, and it will properly disconnect if that client process dies for any reason.

@stepro stepro added the bug Something isn't working label Jun 5, 2020
@stepro stepro added this to the Backlog milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant