Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs #29

Open
andykirk opened this issue Apr 6, 2018 · 3 comments
Open

Updating docs #29

andykirk opened this issue Apr 6, 2018 · 3 comments

Comments

@andykirk
Copy link

andykirk commented Apr 6, 2018

Hi,
I'm opening this issue to discuss any queries I have while I update the docs as previously discussed.

First off, the following ApiMethodsTrait methods do not appear in API-GUIDE.md

getCurrentUser
getCurrentUserBoards
getCurrentUserPinnedBoards
getCurrentUserCards
getCurrentUserOrganizations

I'd like to check if there was any reason for that?

Cheers

@andykirk
Copy link
Author

andykirk commented Apr 6, 2018

Also, the following methods listed in API-GUIDE.md do not appear in the ApiMethodsTrait $methods array.

getAuthorizationUrl
addBatchUrl
getBatchUrls

Edit - I'm guessing these discrepancies are just a result of the $methods being updated ahead of the docs so they're out of sync, but I just wanted to check there wasn't any other reason.

@stevenmaguire
Copy link
Owner

The 'getCurrent...' methods may truly be an oversight.

The second set of methods you mentioned are implemented from two different traits included in the Trello client class. The ApiMethodsTrait is not exhaustive; it does most of the heavy lifting for basic requests that require additional handling.

@andykirk
Copy link
Author

andykirk commented Apr 6, 2018

Ahhh, of course! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants