Fixed bug which caused tdm_installer to reanalyze installation after TDM run.

The analysis was run because TDM repacked tdm_base01.pk4.
The reason it repacked tdm_base01.pk4 is: it thought "strings/all.lang" had "png" extension =)
It turns out that idStr::CheckExtension assumes that extension starts with dot, while in this case it was not.
It does not compare the first character at all =(

Here is the list of changes:
1) idStr::CheckExtension now asserts that first character of extension is "."
2) Function DoNotCompressFile now prepends "." to extension name before calling CheckExtension (that's the main bugfix).
3) stdext::iends_with now calls new idStr::IendsWith instead of idStr::CheckExtension.

As far as I see, DoNotCompressFile and stdext::iends_with were the only calls to CheckExtension without dot.
Also stdext::iends_with is only called in MissionManager for l10n packs, so even if I break it, it won't be a big problem =)


git-svn-id: http://svn.thedarkmod.com/svn/darkmod_src/trunk@9817 49c82d7f-2e2a-0410-a16f-ae8f201b507f

Author: stgatilov

framework/FileSystem.cpp

@@ -1151,9 +1151,12 @@ That's why if we detect that such a file is compressed in pk4, we recompress the
 */
 #include "CompressionParameters.h"
 bool DoNotCompressFile(const char *filename) {
-	for (int i = 0; i < PK4_UNCOMPRESSED_EXTENSIONS_COUNT; i++)
-		if (idStr::CheckExtension(filename, PK4_UNCOMPRESSED_EXTENSIONS[i]))
+	char ext[16] = ".";
+	for (int i = 0; i < PK4_UNCOMPRESSED_EXTENSIONS_COUNT; i++) {
+		strcpy(ext + 1, PK4_UNCOMPRESSED_EXTENSIONS[i]);
+		if (idStr::CheckExtension(filename, ext))
 			return true;
+	}
 	return false;
 }
 

idlib/StdString.cpp

@@ -61,6 +61,6 @@ namespace stdext {
 	}
 
 	bool iends_with(const std::string &text, const std::string &suffix) {
-		return idStr::CheckExtension(text.c_str(), suffix.c_str());
+		return idStr::IendsWith(text.c_str(), suffix.c_str());
 	}
 }

idlib/Str.cpp

@@ -443,12 +443,35 @@ void idStr::StripMediaName( const char *name, idStr &mediaName ) {
 	}
 }
 
+/*
+=============
+idStr::IendsWith
+=============
+*/
+bool idStr::IendsWith( const char *text, const char *suffix ) {
+	int textLen = Length( text );
+	int suffLen = Length( suffix );
+	if ( suffLen > textLen )
+		return false;
+	int offset = textLen - suffLen;
+
+	for ( int i = 0; i < suffLen; i++ ) {
+		char c1 = text[offset + i];
+		char c2 = suffix[i];
+		if ( ToLower(c1) != ToLower(c2) )
+			return false;
+	}
+
+	return true;
+}
+
 /*
 =============
 idStr::CheckExtension
 =============
 */
 bool idStr::CheckExtension( const char *name, const char *ext ) {
+	assert( ext && ext[0] == '.' );
 	const char *s1 = name + Length( name ) - 1;
 	const char *s2 = ext + Length( ext ) - 1;
 	int c1, c2, d;

idlib/Str.h

@@ -260,6 +260,7 @@ class idStr {
 	static int			FindText( const char *str, const char *text, bool casesensitive = true, int start = 0, int end = -1 );
 	static bool			Filter( const char *filter, const char *name, bool casesensitive );
 	static void			StripMediaName( const char *name, idStr &mediaName );
+	static bool			IendsWith( const char *text, const char *suffix );
 	static bool			CheckExtension( const char *name, const char *ext );
 	static const char *	FloatArrayToString( const float *array, const int length, const int precision );