Merge pull request #24 from stiermid/fix-minor-bugs

fix: three minor code quality fixes

Author: Agil Mammadov

nnote/commands/backup.py

@@ -41,7 +41,7 @@ def backup(output_path, directory, include_config, dry_run, quiet):
     if not root.exists():
         raise click.ClickException(f"Directory not found: {root}")
 
-    config_path = Path("~/.config/nnote/config.yaml").expanduser()
+    config_path = config.path
 
     if dry_run:
         count = 0

nnote/config.py

@@ -52,7 +52,7 @@ def save(self) -> None:
             with os.fdopen(fd, "w", encoding="utf-8") as f:
                 yaml.dump(self._data, f, default_flow_style=False, allow_unicode=True)
             Path(tmp).replace(self._path)
-        except:
+        except Exception:
             os.unlink(tmp)
             raise
 

nnote/notes.py

@@ -22,4 +22,4 @@ def open_in_editor(config: Config, path: Path) -> None:
         raise click.ClickException(
             "No editor configured. Set 'editor' in config or the $EDITOR environment variable."
         )
-    subprocess.call([config.editor, str(path)])
+    subprocess.run([config.editor, str(path)], check=False)