Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint rules for mixed indentation #201

Open
a-frantz opened this issue Sep 29, 2024 · 0 comments
Open

lint rules for mixed indentation #201

a-frantz opened this issue Sep 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@a-frantz
Copy link
Member

a-frantz commented Sep 29, 2024

We already have CommandSectionMixedIndentation but we need to rework it a bit.

  • The SPEC has changed how mixed indentation is handled between v1.1 and v1.2 (and maybe from v1.0 to v1.1? Need to check) and the rules need to correctly handle this across different versions
  • The existing rule only looks at command sections as they correctly deserve special treatment
    • But we also need to check for an entire document
    • IMO inside a command block mixed indentation is warning worthy, as it can impact parsing
    • Outside the command block we probably only want to emit a note
  • Undecided on whether this should all be controlled by one rule or if we should divide and conquer
@a-frantz a-frantz added the enhancement New feature or request label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant