Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of numerics throughout the toolbox #5

Open
jbect opened this issue Aug 4, 2020 · 0 comments
Open

Improve consistency of numerics throughout the toolbox #5

jbect opened this issue Aug 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@jbect
Copy link
Member

jbect commented Aug 4, 2020

stk_param_relik uses a combination of "filtering matrix" (obtained using QR) and a Cholesky factorizations of the filtered covariance matrix. This computational approach could/should be encapsulated in a class similar to (but distinct from) stk_kreq_qr.

Other parts of the toolbox work with a different computational approach, encapsulated in stk_kreq_qr (namlely, a QR factorization of the "kriging matrix"). Why not use the same technique in stk_param_relik as well? For instance, it should be possible to compute the restricted likelihood from an stk_model_gpposterior object very quickly (since everything has been pre-computed).

Ideally, once both approaches (and possibly others !) have been properly encapsulated, it should be possible to switch transparently between them for all computations in the toolbox—likelihoods and predictions.

(ref orginal ticket on SourceForge: https://sourceforge.net/p/kriging/tickets/5/)

@jbect jbect added the enhancement New feature or request label Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant