You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was thinking about for a little bit and wanted to open issue this issue mostly to host some discussion.
Currently pyads is published only as a source package, no wheels at all: https://pypi.org/project/pyads/#files.
When installed on Linux/Mac, adslib is always compiled during install and the resulting .so library is dumped amidst the pyads source code, where it's dynamically loaded at runtime.
This definitely works, but I feel it's not according to modern standard and could be improved.
I would suggest we distribute mainly as wheels instead. So we'd publish:
A wheel for Linux, already including the compiled adslib (and no adslib source)
A wheel for MacOS, already including the compiled adslib (and no adslib source)
A wheel for Windows, containing only the pyads source and no adslib source or binaries
A source distribution for platforms falling through the cracks, with the adslib source and no binaries so they can be compiled during installation
This way most installations shouldn't require any compilation at all.
I'm pretty far with an example of this already.
The text was updated successfully, but these errors were encountered:
I was thinking about for a little bit and wanted to open issue this issue mostly to host some discussion.
Currently
pyads
is published only as a source package, no wheels at all: https://pypi.org/project/pyads/#files.When installed on Linux/Mac,
adslib
is always compiled during install and the resulting.so
library is dumped amidst thepyads
source code, where it's dynamically loaded at runtime.This definitely works, but I feel it's not according to modern standard and could be improved.
I would suggest we distribute mainly as wheels instead. So we'd publish:
adslib
(and noadslib
source)adslib
(and noadslib
source)pyads
source and noadslib
source or binariesadslib
source and no binaries so they can be compiled during installationThis way most installations shouldn't require any compilation at all.
I'm pretty far with an example of this already.
The text was updated successfully, but these errors were encountered: