From 7132578d4c1d92e8c7afa777c0ac2e29855a2bdd Mon Sep 17 00:00:00 2001 From: Javier Cardona Date: Sat, 27 Jan 2024 21:34:19 +0000 Subject: [PATCH] Fix shared reference of mutable static warning (#234) This fixes this warning: warning: shared reference of mutable static is discouraged --> stm32l0xx-hal/src/signature.rs:45:40 | 45 | core::str::from_utf8_unchecked(&DEVICE_ID_STR) | ^^^^^^^^^^^^^^ shared reference of mutable static | = note: for more information, see issue #114447 = note: reference of mutable static is a hard error from 2024 edition = note: mutable statics can be written to by multiple threads: aliasing violations or data races will cause undefined behavior = note: `#[warn(static_mut_ref)]` on by default help: shared references are dangerous since if there's any kind of mutation of that static while the reference lives, that's UB; use `addr_of!` instead to create a raw pointer Co-authored-by: Javier Cardona --- src/signature.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/signature.rs b/src/signature.rs index 213d6ee..085bb3b 100644 --- a/src/signature.rs +++ b/src/signature.rs @@ -42,7 +42,7 @@ pub fn device_id_hex() -> &'static str { }); } - core::str::from_utf8_unchecked(&DEVICE_ID_STR) + core::str::from_utf8_unchecked(&*core::ptr::addr_of!(DEVICE_ID_STR)) } }