Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI begin() usage does not follow Arduino API #2

Closed
fpistm opened this issue Nov 10, 2023 · 1 comment
Closed

SPI begin() usage does not follow Arduino API #2

fpistm opened this issue Nov 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@fpistm
Copy link
Member

fpistm commented Nov 10, 2023

Hi @cparata
it seems the library does not follows the standard Arduino SPI API as the CS_PIN is passed to begin()

Since I've aligned the API, the library cannot build.
stm32duino/Arduino_Core_STM32#2171

Anyway without this change, I think the CS_PIN is not required here as the VL53L8CX library manage itself the CS pin
https://github.com/stm32duino/VL53L8CX/blob/7656f3dbe704aa7d40383bde1a877918613317aa/src/platform.cpp#L131C19-L134

@fpistm fpistm added the bug Something isn't working label Nov 10, 2023
@cparata
Copy link
Contributor

cparata commented Nov 10, 2023

Fixed in release 1.0.1

@cparata cparata closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants