-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inaccurate partials proof marked as OG proof #42
Comments
Thanks for reporting. Does the dot turn cyan if you resize the terminal (w tool running) to be shorter in height? |
Ok, I've been able to reproduce it now. And understand what is going on. This is triggered when it finds 2 proofs, it seems. And possibly only submits a partial for 1? |
pulling latest ( 1dbc2c1 ) fixed this issue. |
Huh? that makes absolutely no sense, to run 48 full nodes on one machine.
Are you sure you actually have that many running? How would you even start
that many nodes?
…On Sun, Jul 11, 2021 at 12:36 AM Kaster Might ***@***.***> wrote:
I have those as well. Too many in fact. Not paying too much attention
though, because I know those are not OG proofs by looking at my shiny empty
wallet :D
[image: Screenshot from 2021-07-10 12-16-00]
<https://user-images.githubusercontent.com/2565943/125174231-9eb63b00-e178-11eb-97ad-b0416e935f93.png>
Can you email your debug.log to b.stolk at gmail.com please? I would like
to test a fix on your log.
OK I did. My ideas is there's some race condition going on since I have 48
full_nodes running (number of my cores) and sometimes they write in off
order. I can see that you check for "Submitting partials" entries after
"Found n proofs" entries, and I noticed that sometimes "submitting" entries
come earlier than the "found" entries. But I might be wrong, so good luck
with debugging.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPE4E5VMX75S2MAJXBDRLTXFCZXANCNFSM5AEPJL7A>
.
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
|
Those are threads of a single process. A thread per peer connection,
probably.
On Sun, Jul 11, 2021 at 8:56 AM Kaster Might ***@***.***>
wrote:
Huh? that makes absolutely no sense, to run 48 full nodes on one machine.
Are you sure you actually have that many running? How would you even start
that many nodes?
… <#m_-1223658502728578559_>
On Sun, Jul 11, 2021 at 12:36 AM Kaster Might *@*.
*> wrote: I have those as well. Too many in fact. Not paying too much
attention though, because I know those are not OG proofs by looking at my
shiny empty wallet :D [image: Screenshot from 2021-07-10 12-16-00]
https://user-images.githubusercontent.com/2565943/125174231-9eb63b00-e178-11eb-97ad-b0416e935f93.png
<https://user-images.githubusercontent.com/2565943/125174231-9eb63b00-e178-11eb-97ad-b0416e935f93.png>
Can you email your debug.log to b.stolk at gmail.com <http://gmail.com>
please? I would like to test a fix on your log. OK I did. My ideas is
there's some race condition going on since I have 48 full_nodes running
(number of my cores) and sometimes they write in off order. I can see that
you check for "Submitting partials" entries after "Found n proofs" entries,
and I noticed that sometimes "submitting" entries come earlier than the
"found" entries. But I might be wrong, so good luck with debugging. — You
are receiving this because you were assigned. Reply to this email directly,
view it on GitHub <#42 (comment)
<#42 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADPE4E5VMX75S2MAJXBDRLTXFCZXANCNFSM5AEPJL7A
<https://github.com/notifications/unsubscribe-auth/AADPE4E5VMX75S2MAJXBDRLTXFCZXANCNFSM5AEPJL7A>
. -- Owner/Director of Game Studio Abraham Stolk Inc. Vancouver BC, Canada
@.*
afaik they start automatically when i do chia start farmer.
[image: Screenshot from 2021-07-11 08-56-13]
<https://user-images.githubusercontent.com/2565943/125201878-e2b34980-e225-11eb-8862-e5bb5eb8b01d.png>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPE4AFQQMYTCBUAEXLTIDTXG5MHANCNFSM5AEPJL7A>
.
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
|
Hi. Those are not threads as they have separate PIDs and TGIDs. I dont' think it matters though. I saw your email, but I still can see blue squares. Maybe you had different branch or something. I'm on latest master. Recompiled and everything. Attaching both screenshots and the log file here just in case. PS: I noticed that if the terminal window is short enough, blue squares disappear. Maybe that's what you're seeing. |
I want share my log as I have simplest (single machine run full farmer) case and I do see the problem too. Basically, in the log, sometime, the "Submitting partial" log line doesn't immediate after the eligible line. I have 2 such cases that show blue dot but are actually pool proof. I think this is a race condition that these 2 lines are from different process. So the order is not guaranteed, see the logging process name (farmer vs harvester) below: 2021-07-12T16:42:04.397 harvester chia.harvester.harvester: INFO 2 plots were eligible for farming 686599092a... Found 0 proofs. Time: 0.35231 s. Total 798 plots 2021-07-13T06:56:25.522 harvester chia.harvester.harvester: INFO 1 plots were eligible for farming 4c1214cc87... Found 0 proofs. Time: 0.20828 s. Total 799 plots BTW, your tool is really useful and thanks for your hard work!! |
Hi @stolk Can you give a little update on this? I just want to understand if a) it's not a bug but a feature, b) it's a bug but not fixable at the moment. Thanks. |
I was over thinking it, really...
I don't think there will ever be a farmer that farms both solo plots and
pooled plots.
So if there is a single pool proof seen, all proofs can be considered
non-solo.
I will make a change to reflect this.
…On Sat, Aug 7, 2021 at 3:47 PM Kaster Might ***@***.***> wrote:
Hi @stolk <https://github.com/stolk> Can you give a little update on
this? I just want to understand if a) it's not a bug but a feature, b) it's
a bug but not fixable at the moment. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPE4EV5I6IJIIX2EWURZTT3WZYHANCNFSM5AEPJL7A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
|
This should be fixed now. Sync to latest.
…On Sat, Aug 7, 2021 at 4:46 PM Bram Stolk ***@***.***> wrote:
I was over thinking it, really...
I don't think there will ever be a farmer that farms both solo plots and
pooled plots.
So if there is a single pool proof seen, all proofs can be considered
non-solo.
I will make a change to reflect this.
On Sat, Aug 7, 2021 at 3:47 PM Kaster Might ***@***.***>
wrote:
> Hi @stolk <https://github.com/stolk> Can you give a little update on
> this? I just want to understand if a) it's not a bug but a feature, b) it's
> a bug but not fixable at the moment. Thanks.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#42 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADPE4EV5I6IJIIX2EWURZTT3WZYHANCNFSM5AEPJL7A>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
|
Seems to be working now :) I generally agree that soon pretty much no one will be doing both solo and pool. but at right this moment I know at least 5 people doing it. Not me though. |
Are those people running multiple fullnodes and multiple farmers?
Then it should be ok, they will run multiple graph tools.
On Sun, Aug 8, 2021 at 1:35 AM Kaster Might ***@***.***> wrote:
Seems to be working now :) I generally agree that soon pretty much no one
will be doing both solo and pool. but at right this moment I know at least
5 people doing it. Not me though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPE4CW5F7TC4YUAX4SE6LT3Y6WHANCNFSM5AEPJL7A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
Owner/Director of Game Studio Abraham Stolk Inc.
Vancouver BC, Canada
***@***.***
|
Not really. They still have their OG plots and nft plots on a single machine. They basically have a spare space to fill with nft plots and at the same time they keep solo farming OG plots. I was in the same boat but not anymore. I replaced all my OG plots with NFT plots already, and I'm sure soon everyone will be done with the same process. Depends on the farm size I guess. |
just another idea, is it possible to include full node for full proof detection? basically we should look for the following line for full block?
|
I suspected that there are issue where partials proof were parsed
from reddit
The text was updated successfully, but these errors were encountered: