Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Configurable Keyboard Shortcuts #26

Open
tsumo opened this issue Nov 23, 2016 · 3 comments
Open

Feature Request: Configurable Keyboard Shortcuts #26

tsumo opened this issue Nov 23, 2016 · 3 comments

Comments

@tsumo
Copy link

tsumo commented Nov 23, 2016

Self-explanatory.

@ethanyu336
Copy link

+1, hope j/k for scroll up/down,

@jjvbsag
Copy link

jjvbsag commented Oct 25, 2018

👍 would like to have ESC to close application

@frnco
Copy link

frnco commented May 11, 2020

+1, hope j/k for scroll up/down,

Correct me if I'm wrong, but wouldn't this be easily achievable by changing src/ComicMainWindow.ui

Lines

<action name="actionScrollUp">
    <property name="text">
    <string>Scroll up</string>
   </property>
   <property name="shortcut">
    <string>Up</string>
   </property>
  </action>
  <action name="actionScrollDown">
   <property name="text">
    <string>Scroll down</string>
   </property>
   <property name="shortcut">
    <string>Down</string>
   </property>
  </action>

Changing <string>Up</string> and <string>Down</string> fixes for this use-case.

would like to have ESC to close application
Same here, only on line 253:

<action name="actionQuit">
   <property name="text">
    <string>Quit</string>
   </property>
   <property name="shortcut">
    <string>Ctrl+Q</string>
   </property>
   <property name="menuRole">
    <enum>QAction::QuitRole</enum>
   </property>
  </action>

Changing <string>Ctrl+Q</string> Should also solve this use-case.

I think focusing on specifics is quite bad in this case, what is needed is really a way to allow users to configure their shortcuts on the fly, without any programming needed. Anything less than that is at most postponing the problem (Unless you do this for your personal use, then by all means, do change stuff and compile it by yourself, I'm a vocal supporter of changing and compiling stuff for your personal use. :D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants