Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access rights on /tmp/qcomics-????????? folders are too permissive #39

Open
chrisaga opened this issue Sep 13, 2020 · 0 comments · May be fixed by #27
Open

Access rights on /tmp/qcomics-????????? folders are too permissive #39

chrisaga opened this issue Sep 13, 2020 · 0 comments · May be fixed by #27

Comments

@chrisaga
Copy link

I have installed QComicBook 0.9.1 from apt on Ubuntu 20.04 focal and noticed that /tmp/qcomics-????????? folders are readable fby group and others.
IMHO these folders should be readable by user only.

Rgds.
Chris
pinotree added a commit to pinotree/QComicBook that referenced this issue Nov 24, 2020
@pinotree
Fix creation of temporary directory
0792507 
Since QComicBook switched to Qt5, it is posssible to use QTemporaryDir
to create temporary directories: this solves few problems:
- picking a unique random name
- creating safely the directory (so far the temporary directory has been
  readable by anyone, not just the user, leaving a data leak)
- cleanup is done automatically, in the same way, no matter what is the
  structure of the files there

Fixes: stolowski#39
@pinotree pinotree linked a pull request May 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix creation of temporary directory pinotree/QComicBook
1 participant
@chrisaga