Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Lens should source from original image, not scaled view #29

Open
DrMcCoy opened this issue Jan 28, 2017 · 0 comments
Open

Comments

@DrMcCoy
Copy link

DrMcCoy commented Jan 28, 2017

Currently, the lens seems to scale the current view, instead of the original image.

This doesn't matter this much if the scaled view is roughly equal in size to the original image or bigger. But if the original image is substantially large (for example, if the page is a two-page spread and the view is set to "Fit Width"), especially if the text then is quite small, upscaling the scaled down image leads to a text that's not really all that readable. Ideally, the lens should instead source from the original image.

Of course, that complicates the lens scaling math a bit. Instead of just applying a 2x/3x (or whatever qcomicbook does) do the current view, you need to take the current scale factor into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant