Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Custom Page Scaling #38

Open
frnco opened this issue May 11, 2020 · 0 comments
Open

Feature Request: Custom Page Scaling #38

frnco opened this issue May 11, 2020 · 0 comments

Comments

@frnco
Copy link

frnco commented May 11, 2020

The original/fit width/fit height/etc. options are nice, but can be a pain, especially when using continuous mode in widescreen hi-resolution laptop monitors.

Adding other variations could help, but ideally there would be a custom zoom option (i.e. Zoom Slider and/or shortcut Ctrl plus either +or - seen in many other programs).

Seeing as many programs use some form of custom scaling, I imagine it should be somewhat straightforward to implement, I'm currently considering forking the project to work on a fix, since I find QComicBook quite better than pretty much every other alternative I've tried. Depends on how much time I have, the possibility of me finding a software that already does it, and how much of a Pain it is to fix this vs. fixing other stuff or even making something more barebones from scratch.

If there's any interest I'll try to prioritize adding this feature to QComicBook though, since I find it pretty great, so do tell me if that's the case.

Edit: For now I'll just be using a custom version of

    const double wRatio = static_cast<double>(viewW) / totalWidth;

and

else if (size == FitWidth)
    {
        pixmapWidth = viewW;
        pixmapHeight = static_cast<int>(static_cast<double>(totalHeight) * wRatio);
    }

to fit my needs. From what I see, it'd most likely be easier to either change BestFit or add a new option, instead of adding the whole custom scaling stuff. Especially considering this project is pretty stable and hasn't seen much change in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant