Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved layout styling, and other tales #114

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Peeja
Copy link
Member

@Peeja Peeja commented Aug 2, 2024

This was mainly a sweep of uses of h-screen, as it was breaking on viewports shorter than the page contents, which was particularly nasty on the Pricing page, which is long. I've also:

  • Tweaked how the rooster shows up on small-width screens
  • Made the "Terms of Service" text on the login screen black rather than white for readability
  • Made the hamburger menu icon red rather than write for readability
  • Changed "w3up" to "Storacha"

Unfortunately, we don't have Storybook and Chromatic (or similar) to see all the diffs, but I've screenshotted what I could. Note that these are all full-page screenshots; the fact that the befores are cut off at the top is exactly the problem I was solving here. 🙂

Plenty of this is subjective; thoughts, feedback, and corrections are more than welcome.

Before

screencapture-localhost-3000-2024-08-02-16_00_56
screencapture-localhost-3000-2024-08-02-16_02_16
screencapture-localhost-3000-2024-08-02-16_15_53
screencapture-localhost-3000-2024-08-02-16_16_38
screencapture-localhost-3000-2024-08-02-16_27_53

After

screencapture-localhost-3000-2024-08-02-16_01_30
screencapture-localhost-3000-2024-08-02-16_07_23
screencapture-localhost-3000-2024-08-02-16_16_06
screencapture-localhost-3000-2024-08-02-16_16_56
screencapture-localhost-3000-2024-08-02-16_28_11

This appears to be highly duplicated from `SidebarLayout`, but isn't itself used at all.
@Peeja Peeja requested a review from alanshaw August 2, 2024 20:59
@Peeja Peeja changed the title Improved layout styling, and other tales feat: Improved layout styling, and other tales Aug 2, 2024
@Peeja Peeja merged commit d0a2208 into feat/storacha-skin Aug 12, 2024
1 of 2 checks passed
@Peeja Peeja deleted the fix-vertical-centering branch August 12, 2024 19:33
@Peeja Peeja restored the fix-vertical-centering branch August 12, 2024 19:33
@Peeja Peeja deleted the fix-vertical-centering branch August 12, 2024 19:33
hannahhoward pushed a commit that referenced this pull request Sep 20, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.10.0](w3console-v1.9.1...w3console-v1.10.0)
(2024-09-20)


### Features

* change email
([7c7beb7](7c7beb7))
* **copy:** Add missing comma
([#115](#115))
([97f1ac3](97f1ac3))
* Improved layout styling, and other tales
([#114](#114))
([d0a2208](d0a2208))
* more styles
([d4e8efa](d4e8efa))
* styles for upload page
([6c54798](6c54798))
* trigger deploy
([a8f1089](a8f1089))
* wording
([ffe9b1b](ffe9b1b))


### Bug Fixes

* apostrophe
([681b9b8](681b9b8))
* check ref
([f406ac9](f406ac9))
* deploy-storacha.yml needs to use the new main branch
([#122](#122))
([65644c8](65644c8))
* deploy.yml needs to use the old-main branch
([#120](#120))
([713af05](713af05))
* quotes
([bcf209b](bcf209b))
* **space-creator:** check provision result before proceeding
([#119](#119))
([5ea5940](5ea5940))
* use correct branch name
([f81e090](f81e090))
* use main branch
([698974b](698974b))


### Other Changes

* add storacha deploy action
([39345e6](39345e6))
* Set `packageManager`
([#117](#117))
([c9436fc](c9436fc))
* update deploy name
([f7c1340](f7c1340))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants