Typescript 5 #418
Closed
Typescript 5 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
typescript-5
branch
from
20f60f7
to
346fd91
Compare
hannahhoward
changed the base branch from
main
to
fix/disable-filecoin-test-for-now
hannahhoward
changed the base branch from
fix/disable-filecoin-test-for-now
to
main
hannahhoward
changed the base branch from
main
to
fix/disable-filecoin-test-for-now
currently, seed.run fails 90%+ of the time because of the Filecoin test. until we have a more reliable way to test the filecoin flow, the PR disables it. the inserted comment suggests a few solutions -- either spinning up custom infra for w3filecoin pipeline on each pr to get more reliable results, or mocking out the pipeline
hannahhoward
force-pushed
the
fix/disable-filecoin-test-for-now
branch
from
346fd91
to
13462fa
Compare
hannahhoward
force-pushed
the
typescript-5
branch
from
53f6185
to
4ecbae3
Compare
This reverts commit ba8400a.
|
@Peeja I'd like to close this out to reclaim IAM resources, wdyt? |
|
Looks like the intended changes from this PR have already landed separately. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
@importJSDoc tag for #417. Upgrading TypeScript tends to be pretty safe, and iftscpasses, it should be good.Also adds a
packageManagerfield topackage.jsonso people like me don't get confused over which repos usenpmand which usepnpm. 😄