fix!: use MultihashDigest type in stores #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
changed the title
| @@ -126,21 +124,17 @@ export class BlobsStorage { | |||
| this.content = content | |||
| } | |||
|
|
|||
| /** @param {import('multiformats').MultihashDigest} digest */ | |||
| /** @param {Types.MultihashDigest} digest */ | |||
| #bucketPath(digest) { | |||
There was a problem hiding this comment.
nit: could we call this param multihashDigest everywhere? it feels weird now, and we have some digest.digest
There was a problem hiding this comment.
So verbose though, and we very rarely use digest.digest... 😄
There was a problem hiding this comment.
mhDigest instead? 😅
anyway, I don't strongly oppose if you want to keep as this
alanshaw
force-pushed
the
fix/use-multihashdigest-type1
branch
from
739e02c
to
d9bd509
Compare
This was referenced Jun 7, 2024
alanshaw
pushed a commit
that referenced
this pull request
Jun 10, 2024
🤖 I have created a release *beep* *boop* --- ## [18.0.0](upload-api-v17.1.0...upload-api-v18.0.0) (2024-06-07) ### ⚠ BREAKING CHANGES * `AllocationsStorage` and `BlobsStorage` methods not take `MultihashDigest` types instead of `Uint8Array`s. ### Features * publish index claim ([#1487](#1487)) ([237b0c6](237b0c6)) ### Fixes * stop writing to DUDEWHERE ([#1500](#1500)) ([cf0a1d6](cf0a1d6)) * use MultihashDigest type in stores ([#1474](#1474)) ([6c6a3bd](6c6a3bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
alanshaw
pushed a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop* --- ## [15.0.0](w3up-client-v14.1.1...w3up-client-v15.0.0) (2024-06-13) ### ⚠ BREAKING CHANGES * `AllocationsStorage` and `BlobsStorage` methods not take `MultihashDigest` types instead of `Uint8Array`s. ### Features * utility exports for better UX ([#1505](#1505)) ([54b0d93](54b0d93)) ### Fixes * use MultihashDigest type in stores ([#1474](#1474)) ([6c6a3bd](6c6a3bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces callers to decode
Uint8Arraysthat may come from user input before the storage method is called and that means we don't just use them without validation that they are actually a multihash.BREAKING CHANGE:
AllocationsStorageandBlobsStoragemethods not takeMultihashDigesttypes instead ofUint8Arrays.