Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry close operation depending of the returned error #51

Open
ifraixedes opened this issue Dec 21, 2022 · 0 comments
Open

Retry close operation depending of the returned error #51

ifraixedes opened this issue Dec 21, 2022 · 0 comments
Labels
crate:uplink Specific issues / PRs for uplink crate status:under-discussion Issues / PRs on hold for a future decision

Comments

@ifraixedes
Copy link
Collaborator

ifraixedes commented Dec 21, 2022

Some Drop trait implementations call the bindings for closing resources.
The bindings may return an error, however, we cannot handle it because it's when the instance of the type is removed from memory, so we have to leak the resource.

One thing that we may implement is retrying the close operation a few times depending on the returned error for avoiding leaking the resource.

I'd like to collect thoughts about if we should retry or not, and if we should retry, under which errors.

Note you can find the source places affected by this issue by searching in the sources TODO(https://github.com/storj-thirdparty/uplink-rust/issues/51).

@ifraixedes ifraixedes added crate:uplink Specific issues / PRs for uplink crate status:under-discussion Issues / PRs on hold for a future decision labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate:uplink Specific issues / PRs for uplink crate status:under-discussion Issues / PRs on hold for a future decision
Projects
None yet
Development

No branches or pull requests

1 participant