Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub project #21

Open
storres20 opened this issue Nov 21, 2022 · 2 comments
Open

GitHub project #21

storres20 opened this issue Nov 21, 2022 · 2 comments

Comments

@storres20
Copy link
Owner

Description

@anagudelogu
Copy link

STATUS: CHANGES REQUIRED ♻️ 🚧

Hi team! @storres20,
I'm Andres.

While you have done a great job working on this milestone 💻 , there are some issues that you still need to work on to go to the next project. ♻️

You are almost there, keep up the good work! 🚀

Highlights

✅ Great use of GitHub projects feature. 💯

Required Changes ♻️

  • All cards should have an assignee, decide who will be students A and B, and please assign yourselves to the corresponding tasks. If you don't know how to use this feature, you can refer to this tutorial. 🤓 🛠️

From the project requirements:
image

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Munsa1
Copy link

Munsa1 commented Nov 21, 2022

Hi @Team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✔️ Descriptive Readme
✔️ Passing Linters
✔️ Correct Gitflow

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants