Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI for component tests in story menu #29647

Open
4 tasks
Tracked by #29531
JReinhold opened this issue Nov 18, 2024 · 0 comments
Open
4 tasks
Tracked by #29531

Improve UI for component tests in story menu #29647

JReinhold opened this issue Nov 18, 2024 · 0 comments

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Nov 18, 2024

The UI for the context menu can be improved in a few key areas. We already have a design ready that we can implement.

For reference, this is the current UI:

Image

Here are the designs we want to implement instead (as of 2024-11-18):

Image
Image
Image

The core differences from an implementation perspective is:

  1. The current design has a split between "Story statuses" (top) and "any menu item content" (bottom), but the new design puts all content into a single "slot". So addon-test has a slot, and Visual Tests have a slot.
  2. All (sub)test types (Component tests, a11y, coverage, etc.) must always be shown, even when they haven't run yet. This conflicts directly with the Story Status API where stories only have statuses when something has happened (failed/success/running). in combination with 1, we can't use Story Statuses for content here, addon-test has to internally figure out what content and statuses to show instead. So we'll only use the Story Status API for the dots in the sidebar, not the content in the menu.
  3. The new designs have an "edit mode" that essentially functions the same as the Testing Module UI, allowing you to disable/enable any sub test types.

For that reason, we've identified the following tasks:

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant