Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filterered stories from test #449

Open
zb-sj opened this issue Apr 15, 2024 · 3 comments
Open

Remove filterered stories from test #449

zb-sj opened this issue Apr 15, 2024 · 3 comments

Comments

@zb-sj
Copy link

zb-sj commented Apr 15, 2024

My sub test only needs one story to test but the current tag filtering implementation creates redundant describe.skip(${title}, () => { it('no-op', () => {}) }); as per makeDescribe

It wastes noticeable time just to skip those tests.

Wouldn't it be better not to generate a description for filtered tests? I see there is skipTags for the exact purpose.

Please let me know what you think and I could probably make a quick PR for this.

@yannbf
Copy link
Member

yannbf commented May 17, 2024

Hey there! I'd appreciate a PR. If I recall correctly, it was not possible to do this because of file transformation limitations.

@zb-sj
Copy link
Author

zb-sj commented May 22, 2024

If I recall correctly, it was not possible to do this because of file transformation limitations.

I will have a look, but don't get hopes so high since you would know better than me :)

@zb-sj
Copy link
Author

zb-sj commented Jul 2, 2024

It's been a while but I'm sorry I haven't had much time to look into this. 😢

Please feel free to close this issue for now. I will reopen when I start the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants