feat: Add decision record for HookProviders being too low level for High-Level constructs #1427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yonib05
reviewed
Jan 6, 2026
| @@ -0,0 +1,43 @@ | |||
| # Decision Record | |||
Member
There was a problem hiding this comment.
I love this, but maybe on the docs site?
Unshure
approved these changes
Jan 7, 2026
Member
Unshure
left a comment
Unshure
left a comment
There was a problem hiding this comment.
Love the idea of adding decisions to the sdk. Im fine moving forward with this, but we should consider if this is the right long term place for this information, or if it makes more sense in a central repository (like docs or another new repo).
Additionally, when Agents consume this information, we should create one file per decision to make it easier to progressively disclose this info
Member
Author
|
Aligned on a team that this should be moved to docs. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In doing api bar raising for #1424, we determined that HookProvider is a too-low-level interface for exposing directly to integrators. This captures that decision & reasoning in log format and sets us up to record future decisions in a similar way going forward.
See DECISIONS.md on the decision & the format
Related Issues
N/A
Type of Change
Other (please describe): Record of decision
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.