Structs in cmd folder should be visible to other programs.

[chillyvee]

There are many types defined in the cmd/horcrux/cmd directory which can't be integrated into other programs.

For example:
https://github.com/strangelove-ventures/horcrux/blob/main/cmd/horcrux/cmd/config.go#L543

type CosignerConfig struct {
	Threshold int            `json:"threshold"   yaml:"threshold"`
	Shares    int            `json:"shares" yaml:"shares"`
	P2PListen string         `json:"p2p-listen"  yaml:"p2p-listen"`
	Peers     []CosignerPeer `json:"peers"       yaml:"peers"`
	Timeout   string         `json:"rpc-timeout" yaml:"rpc-timeout"`
}

Can't be referenced from a third party program.

For example we had to recreate the same struct in our program in order to utilize the same structures.
https://github.com/chillyvee/precrux/blob/master/snitch/generate.go#L22

Is it acceptable to extract all these types into https://github.com/strangelove-ventures/horcrux/horcrux/types.go

Or something else like that?

If so we can start to work on a PR. Guidance is welcome.

[agouin]

@chillyvee yes, moving these types into a public package would be fine!