-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make storage interface more friendly #27
Comments
Agreed for the first two points -- on the last, I'd say that individual credentials can be deleted by just setting a new object that omits that credential in particular. Anything wrong with that approach? @nsatragno @inorganik what do you think about adding a new storage interface (and documentation) for the user session as well? That would also give greater control on that front (CC #15) |
Hmmm, I think on a relational database that would require SELECTing the user, diffing against the user authenticators, and figuring out what to delete. I just realized that's the same thing for adding authenticators though 🤔. Maybe that's acceptable for an MVP, and we should consider having two kinds of adapters, one for relational and one for document databases.
+1 |
This patch attempts to formalize the storage interface to make it easier to integrate with existing databases. See issue strangerlabs#27
The storage interface should more easily allow developers to integrate this library with their existing user models, especially for relational databases.
search
should probably be removed since it's not being used.delete
individual credentials).It could also be a good idea to change the attribute
user.authenticator
touser.webauthnCredential
since not all authenticators are webauthn authenticators and in theory the same user could have multiple credentials on the same authenticator, but this is a little bikesheddy :)Blocked on #12
The text was updated successfully, but these errors were encountered: