Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A comment between two rules triggers an infinite loop and maxes out on memory consumption #12

Open
verovaleros opened this issue Nov 29, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@verovaleros
Copy link
Member

In the label's configuration of netflowlabeler, comments are allowed. Usually they are placed at the beginning of the section, like shown below:

# Valid and ok comment
Malicious, Network-service-discovery-telnet:
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=23
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=2323
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=9527

If, however, a comment is placed between the rules, it will enter netflowlabeler in an infinite loop, which will make it consume all available memory and then crash:

# Valid and ok comment
Malicious, Network-service-discovery-telnet:
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=23
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=2323
# this is a comment that is not caught properly and will trigger an unwanted behavior
    - srcIP=192.168.100.103 & Proto=tcp & dstPort=9527
@verovaleros verovaleros added the bug Something isn't working label Nov 29, 2022
@verovaleros verovaleros added this to the v0.6 milestone Nov 29, 2022
@verovaleros verovaleros moved this to 📋 Backlog in Netflow Labeler Nov 29, 2022
@verovaleros verovaleros removed this from the v0.6 milestone Mar 12, 2023
@verovaleros verovaleros added this to the v1.0.0 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants