Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG action result that asserts connection was not dropped #1023

Closed
plebhash opened this issue Jul 1, 2024 · 1 comment · Fixed by #1024
Closed

MG action result that asserts connection was not dropped #1023

plebhash opened this issue Jul 1, 2024 · 1 comment · Fixed by #1024
Assignees
Milestone

Comments

@plebhash
Copy link
Collaborator

plebhash commented Jul 1, 2024

MG currently has an action result that asserts that the connection was closed (CloseConnection)

enum ActionResult {
MatchMessageType(u8),
MatchMessageField((String, String, Vec<(String, Sv2Type)>)),
GetMessageField {
subprotocol: String,
message_type: String,
fields: Vec<SaveField>,
},
MatchMessageLen(usize),
MatchExtensionType(u16),
CloseConnection,
None,
}

However, it is also desirable to have an action result that asserts the opposite: the connection was not closed.

That would be particularly important to avoid #912 happening on future SV2 implementations.

@plebhash plebhash self-assigned this Jul 1, 2024
@plebhash plebhash linked a pull request Jul 1, 2024 that will close this issue
@plebhash plebhash added this to the 1.0.2 milestone Jul 1, 2024
@plebhash plebhash moved this from Todo 📝 to Ready For Review 🔍 in SV2 Roadmap 🛣️ Jul 1, 2024
@plebhash plebhash moved this from Ready For Review 🔍 to Done ✅ in SV2 Roadmap 🛣️ Jul 2, 2024
@plebhash plebhash moved this from Done ✅ to In Progress 🏗️ in SV2 Roadmap 🛣️ Jul 2, 2024
@plebhash plebhash moved this from In Progress 🏗️ to Done ✅ in SV2 Roadmap 🛣️ Jul 9, 2024
@plebhash
Copy link
Collaborator Author

plebhash commented Jul 9, 2024

closed via #1024

@plebhash plebhash closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant