Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naive MG test on CloseChannel, potential naive behavior on tProxy #1081

Open
plebhash opened this issue Aug 5, 2024 · 1 comment
Open

naive MG test on CloseChannel, potential naive behavior on tProxy #1081

plebhash opened this issue Aug 5, 2024 · 1 comment
Labels
message-generator test Test related translation proxy SV1>SV2 translation proxy issues

Comments

@plebhash
Copy link
Collaborator

plebhash commented Aug 5, 2024

It's not clear what pool-sri-test-close-channel tries to achieve.

There's nothing in the specs stating that a proxy must close the entire connection when it receives a CloseChannel from Upstream.

This feels like a naive test. What if the proxy has other active channels?

Also relevant:

Mining::CloseChannel(_m) => {
error!("Received Mining::CloseChannel msg from upstream!");
handle_result!(tx_status, Err(NoUpstreamsConnected));
}

@plebhash plebhash changed the title dummy MG test on CloseChannel naive MG test on CloseChannel Aug 5, 2024
@plebhash
Copy link
Collaborator Author

plebhash commented Aug 6, 2024

from @Fi3 over Discord:

not sure
depend what we want to test
and what tproxy is expected to do
the thing that make most sense impo
is to close downstream connection
reopen the channel with upstream
and wait for the miner to reconnect
tproxy from what I know can not open more then one channel
so tproxy having more channle opened is impossible
when if tproxy will support more then one channel opened with upstream we can reason about it

@plebhash plebhash changed the title naive MG test on CloseChannel naive MG test on CloseChannel, potential naive behavior on tProxy Aug 6, 2024
@pavlenex pavlenex added test Test related message-generator translation proxy SV1>SV2 translation proxy issues labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
message-generator test Test related translation proxy SV1>SV2 translation proxy issues
Projects
Status: Todo 📝
Development

No branches or pull requests

2 participants