Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDC should stop sending shares upstream if pool prev hash is different from JDC prev hash #1082

Open
Fi3 opened this issue Aug 7, 2024 · 0 comments

Comments

@Fi3
Copy link
Collaborator

Fi3 commented Aug 7, 2024

Right now when the pool send set new prev hash to the JDC, the JDC do nothing. The correct behavior should be:

  1. compare it with the SNP it is mining on
  2. if different stop sending shares upstream (in the future would be nice also to send a signal downstream to pause the miners)
    fn handle_set_new_prev_hash(
        &mut self,
        _: roles_logic_sv2::mining_sv2::SetNewPrevHash,
    ) -> Result<roles_logic_sv2::handlers::mining::SendTo<Downstream>, RolesLogicError> {
        warn!("SNPH received from upstream, proxy ignore it, and use the one declared by JOB DECLARATOR");
        Ok(SendTo::None(None))
    }
@pavlenex pavlenex added this to the 1.0.3 milestone Aug 16, 2024
@plebhash plebhash added the bug Something isn't working label Aug 20, 2024
@plebhash plebhash removed this from the 1.0.3 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo 📝
Development

No branches or pull requests

3 participants