Job_creator in roles_logic_sv2 do not check if coinbase_tx_value_remaining is updated by TP

[Fi3]

In roles_logic_sv2 we have:

    coinbase_outputs[0].value = match new_template.coinbase_tx_value_remaining.checked_mul(1) {
        //check that value_remaining is updated by TP
        Some(result) => result,
        None => return Err(Error::ValueRemainingNotUpdated),
    };

The comment say that we want to check if value remaining is updated by the TP, this make sense. But the code do not do that¹.
Here IMO we can just check if coinbase_tx_value_remaining != 0 with an assertion (is fine to panic here cause if it is 0 tp is sending wrong templates and pool can not work)

Footnotes

1. the code it only verify that an u64 multiplied by one do not overflow, I'm pretty sure that this is impossible. ↩