Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup cargo build warnings #1096

Open
jbesraa opened this issue Aug 13, 2024 · 5 comments
Open

Cleanup cargo build warnings #1096

jbesraa opened this issue Aug 13, 2024 · 5 comments
Assignees
@Arshia-r-m

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Aug 13, 2024

Handle warnings generated when running cargo build, preferably in an incremental way with separate commit for each set of warnings
@rrybarczyk
Copy link
Collaborator

The warnings I see that need to be addressed are:

  1. Cargo.toml unused manifest keys. Do we just delete the lines causing the warning? Then we lose metadata. Is there a way to properly suppress these warnings? What are best practices here?
  2. Code/logic warnings like roles-utils/rpc/src/lib.rs:8:19 and jd-client/src/lib/error.rs:31:5

@Arshia-r-m
Copy link

Are these warnings generate with every cargo build or just the initial one?

@rrybarczyk
Copy link
Collaborator

Are these warnings generate with every cargo build or just the initial one?

Every cargo build. It is quite annoying.

@Arshia-r-m
Copy link

I want to work on this issue, I will put the updates on following comments

@jbesraa
Copy link
Contributor Author

jbesraa commented Sep 6, 2024

sure, go for it

@jbesraa jbesraa mentioned this issue Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arshia-r-m Arshia-r-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbesraa @rrybarczyk @Arshia-r-m