Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency - SV2 or Sv2 and Stratum V2 or Stratum v2 #193

Closed
pavlenex opened this issue Feb 13, 2024 · 6 comments · Fixed by #209
Closed

Improve consistency - SV2 or Sv2 and Stratum V2 or Stratum v2 #193

pavlenex opened this issue Feb 13, 2024 · 6 comments · Fixed by #209
Assignees

Comments

@pavlenex
Copy link
Collaborator

pavlenex commented Feb 13, 2024

Once we're done shipping a release, would be great to consolidate how we use Stratum v2 or Stratum V2 ; SV2 or Sv2 since we're inconsistent across website and docs currently.

Requires community discussion on what to settle for. I invite everyone to leave comments on their preference.

It seems specifications are inconsistent about this topic as well.

@pavlenex
Copy link
Collaborator Author

pavlenex commented Feb 13, 2024

I usually write Stratum v2 and Sv2, so I'd say I'd go with that, though don't think the alternative is a blocker as long as we settle or something.

@pavlenex pavlenex changed the title Improve consistency - SV2 or Sv2 Improve consistency - SV2 or Sv2 and Stratum V2 or Stratum v2 Feb 13, 2024
@Sjors
Copy link

Sjors commented Feb 13, 2024

I usually write Stratum v2 and Sv2

Same. But maybe that's because I copied it from you :-)

@pavlenex
Copy link
Collaborator Author

I guess specs authors call it Stratum V2 and the opening sentence in specs is Stratum V2, from there it's Stratum v2, sv2 and SV2. So it seems Stratum v2 thus SV2 is how it should be.
Screenshot 2024-02-13 at 19 36 36

Again don't really have hard preference as long as we decide as community and then correct inconsistencies 😄

@xyephy
Copy link
Contributor

xyephy commented Apr 17, 2024

Hi @pavlenex is the final conclusion Stratum V2 and SV2?
If so, can I start on the cleanup?

@pavlenex
Copy link
Collaborator Author

Hey @xyephy Correct. Go for it.

@xyephy
Copy link
Contributor

xyephy commented Apr 18, 2024

@pavlenex I've exempted links and examples from changes i.e

./bitcoin-sv2-tp-0.1.2/bin/bitcoind -sv2 -sv2port=8442 -sv2interval=20 -sv2feedelta=1000 -debug=sv2 -loglevel=sv2:trace

(roles/sv2/mining-proxy)

https://github.com/stratum-mining/sv2-spec

Also modified a few Sv1 -> SV1 for uniformity

The fix PR: #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants