Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch config a and b #188

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

pavlenex
Copy link
Collaborator

@pavlenex pavlenex commented Oct 6, 2023

This PR puts an emphasis on configuration with tProxy.

This PR puts an emphasis on configuration with tProxy.
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for startling-capybara-2231ea ready!

Name Link
🔨 Latest commit d973548
🔍 Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/65cf0c62365a8400082a3a1d
😎 Deploy Preview https://deploy-preview-188--startling-capybara-2231ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavlenex
Copy link
Collaborator Author

pavlenex commented Oct 6, 2023

As discussed in #184

@GitGab19 pleasereview for technical accuracy, I'm sure we can still iron out the copy, but wanted to kick-off efforts.

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not completely sure about the best configs order: should we place config C (Translator+JDP) as config B?
Since the only configurations which can be test with real asic machines are the ones with the Translator (?)
What do you think about it?

src/index.md Outdated
@@ -28,12 +28,12 @@ configurationTabs:
value: config_A
visualSrc: /assets/config-a.svg
mobileVisualSrc: /assets/config-a-mobile.svg
textContent: Before Stratum V2, transaction sets were selected by pools. With this SV2 configuration they’re selected by individual miners, making the network more censorship-resistant. Miners run SV2 firmware, connecting to the SV2 proxy server. Miners can pick their transactions locally and declare them to an SV2 pool.
textContent: Miners can utilize Stratum v2 without updating to SV2 firmware. Connect your SV1 firmware devices through Translation Proxy which facilitates the conversion of SV1 messages to SV2 for communication with an SV2 pool. Miners handle transaction selection locally via their own Template Provider, and declare them to a pool. If a pool rejects the proposed transactions, miners automatically switch to an alternative pool. Should all configured pools decline the proposal, miners fallback to solo mining.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to use Sv2/v1 instead of SV2/V1 everywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Stratum v2 so should be Sv2 if that's what you mean?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah Stratum v2 so should be Sv2 if that's what you mean?

Yeah exactly 👍

Copy link
Collaborator Author

@pavlenex pavlenex Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on recent discussions decided to uppercase everything for now both Stratum V2 and SV2, we can always update later based on the outcome in #193

src/index.md Outdated
@@ -43,7 +43,7 @@ configurationTabs:
value: config_D
visualSrc: /assets/config-d.svg
mobileVisualSrc: /assets/config-d-mobile.svg
textContent: In this configuration miners run mining devices with SV1 firmware and connect to the translation proxy which translates the SV1 to SV2 messages and sends them to the SV2 pool. Transaction selection is done by the miners locally and then declared to the pool.
textContent: In this configurations, mining pool select transactions, but it uses all the security and performance features of the SV2 protocol.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • configuration
  • selects

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed d973548

@pavlenex
Copy link
Collaborator Author

pavlenex commented Feb 16, 2024

Still not completely sure about the best configs order: should we place config C (Translator+JDP) as config B? Since the only configurations which can be test with real asic machines are the ones with the Translator (?) What do you think about it?

I am unsure either, however at some point (perhaps sooner than we think) we need to talk about SV2 firmware, and I kinda think it's okay to emphasize that as a possible option, though currently it's not possible, I also wanted to emphasize the configuration where JD is used, since that's the biggest selling point of SV2 for most people.

I think this one is good to go now, applied changes according to your suggestions I'll leave it up to you to make a call, I'd like to merge this one before people start tackling #189 to avoid conflicts and them having to update translations.

Copy link
Collaborator

@GitGab19 GitGab19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you on the configuration order.
LGTM

@pavlenex pavlenex merged commit 3b375ae into stratum-mining:main Feb 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants