Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PAGINATION_DEFAULT_LIMIT pagination setting isn't used #656

Open
SupImDos opened this issue Nov 14, 2024 · 0 comments
Open

New PAGINATION_DEFAULT_LIMIT pagination setting isn't used #656

SupImDos opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@SupImDos
Copy link
Contributor

SupImDos commented Nov 14, 2024

Describe the Bug

The recent release that included PR #642 introduced a new setting, PAGINATION_DEFAULT_LIMIT, which is mentioned in the settings and pagination documentation sections.

However, upon reviewing the PR and the codebase, it appears that PAGINATION_DEFAULT_LIMIT is not actually currently referenced or used anywhere! This suggests that the setting is currently non-functional and does not affect pagination behavior.

Suggested Approach

We should either remove the PAGINATION_DEFAULT_LIMIT setting and its documentation, or implement its expected behaviour. Once the issue with is addressed, it would also be helpful to update the documentation to clarify that Relay pagination limits are controlled separately by the relay_max_results setting from the upstream strawberry package (if still applicable). This setting is documented in the Relay configuration guide.

System Information

  • Operating system: MacOS
  • Strawberry version (if applicable): 0.248.1

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@SupImDos SupImDos added the bug Something isn't working label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant