Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update and improve github workflows #492

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

bellini666
Copy link
Member

No description provided.

@bellini666 bellini666 self-assigned this Mar 3, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request focuses on updating and improving GitHub workflows for both application testing and documentation deployment. It includes updates to the actions used for checking out the repository and setting up Python, simplifies the dependency installation process by leveraging Poetry, and ensures that documentation is deployed using the latest practices. The changes aim to streamline CI/CD pipelines, enhance the reliability of test executions, and improve the efficiency of documentation deployment.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Given the updates to GitHub Actions workflows, it's crucial to ensure that these changes do not inadvertently affect the execution of existing tests. Verifying that the CI pipeline, especially the test steps using pytest, runs successfully with these changes is essential.
  • The simplification of the dependency installation process is a positive change. However, it's important to verify that all necessary dependencies for tests are still correctly installed, particularly if any dependencies are environment-specific or optional but required for tests.
  • While the focus of this PR is not directly on application code or its tests, ensuring that documentation builds and deployments are successful is also important. If the project includes tests for documentation, such as doctests, verifying their successful execution post-changes is advisable.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@bellini666 bellini666 force-pushed the chore/improve_and_update_gh_workflows branch from 99b7222 to 15965c9 Compare March 3, 2024 16:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (bd9b494) to head (4196cfc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   87.92%   87.96%   +0.03%     
==========================================
  Files          37       37              
  Lines        3173     3173              
==========================================
+ Hits         2790     2791       +1     
+ Misses        383      382       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bellini666 bellini666 force-pushed the chore/improve_and_update_gh_workflows branch from 15965c9 to ae9bf15 Compare March 3, 2024 16:38
@bellini666 bellini666 force-pushed the chore/improve_and_update_gh_workflows branch from ae9bf15 to 4196cfc Compare March 3, 2024 16:41
@bellini666 bellini666 merged commit 8c75fd8 into main Mar 3, 2024
52 checks passed
@bellini666 bellini666 deleted the chore/improve_and_update_gh_workflows branch March 3, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants