Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the recommended library for JWT Authentication in Django to strawberry-django-auth #633

Merged

Conversation

pkrakesh
Copy link
Contributor

@pkrakesh pkrakesh commented Sep 29, 2024

Changed the JWT library recommendation from strawberry-django-jwt to strawberry-django-auth in the documentation as the old library is unmaintained and recommends using the latter library by itself.

Summary by Sourcery

Change the recommended JWT authentication library in the Django documentation to 'strawberry-django-auth' as the previous library is no longer maintained.

Documentation:

  • Update the recommended library for JWT authentication in Django documentation from 'strawberry-django-jwt' to 'strawberry-django-auth' due to the former being unmaintained.

Copy link
Contributor

sourcery-ai bot commented Sep 29, 2024

Reviewer's Guide by Sourcery

This pull request updates the documentation to recommend a new library for JWT Authentication in Django. The change replaces the old recommendation of 'strawberry-django-jwt' with 'strawberry-django-auth' due to maintenance issues with the former library.

No sequence diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated JWT library recommendation in the authentication documentation
  • Replaced 'strawberry-django-jwt' with 'strawberry-django-auth'
  • Updated the GitHub link to point to the new recommended library
docs/guide/authentication.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pkrakesh - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

docs/guide/authentication.md Show resolved Hide resolved
@@ -8,7 +8,7 @@ title: Authentication
> This solution is enough for web browsers, but will not work for clients that
> doesn't have a way to store cookies in it (e.g. mobile apps). For those it is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (documentation): Minor grammatical error in unchanged text: 'doesn't have' should be 'don't have'.

Copy link
Contributor

@Ckk3 Ckk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @pkrakesh !
I checked the code and looks good to me!
Lets wait @patrick91 @bellini666 check it out too😉.

Copy link
Member

@bellini666 bellini666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@bellini666 bellini666 enabled auto-merge (squash) September 30, 2024 13:43
@bellini666 bellini666 merged commit b8cb555 into strawberry-graphql:main Sep 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants