-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the recommended library for JWT Authentication in Django to strawberry-django-auth #633
Changed the recommended library for JWT Authentication in Django to strawberry-django-auth #633
Conversation
…trawberry-django-auth
Reviewer's Guide by SourceryThis pull request updates the documentation to recommend a new library for JWT Authentication in Django. The change replaces the old recommendation of 'strawberry-django-jwt' with 'strawberry-django-auth' due to maintenance issues with the former library. No sequence diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pkrakesh - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -8,7 +8,7 @@ title: Authentication | |||
> This solution is enough for web browsers, but will not work for clients that | |||
> doesn't have a way to store cookies in it (e.g. mobile apps). For those it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (documentation): Minor grammatical error in unchanged text: 'doesn't have' should be 'don't have'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @pkrakesh !
I checked the code and looks good to me!
Lets wait @patrick91 @bellini666 check it out too😉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😊
Changed the JWT library recommendation from
strawberry-django-jwt
to strawberry-django-auth in the documentation as the old library is unmaintained and recommends using the latter library by itself.Summary by Sourcery
Change the recommended JWT authentication library in the Django documentation to 'strawberry-django-auth' as the previous library is no longer maintained.
Documentation: