-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Official support for Python 3.13 and drop support for Python 3.8 #643
Conversation
Reviewer's Guide by SourceryThis pull request updates the codebase to officially support Python 3.13 and drops support for Python 3.8. The main changes involve updating type annotations, particularly replacing Updated class diagram for type annotationsclassDiagram
class OneToManyInput {
+Optional~list[strawberry.ID]~ add
+Optional~list[strawberry.ID]~ remove
+Optional~list[strawberry.ID]~ set
}
class ManyToOneInput {
+Optional~list[strawberry.ID]~ add
+Optional~list[strawberry.ID]~ remove
+Optional~list[strawberry.ID]~ set
}
class ManyToManyInput {
+Optional~list[strawberry.ID]~ add
+Optional~list[strawberry.ID]~ remove
+Optional~list[strawberry.ID]~ set
}
class ListInput {
+Optional~list[K]~ set
+Optional~list[K]~ add
+Optional~list[K]~ remove
}
class OperationInfo {
+list[OperationMessage] messages
}
class field_type_map {
+dict[Union[type[fields.Field], type[related.RelatedField], type[reverse_related.ForeignObjectRel]], type] field_type_map
}
class input_field_type_map {
+dict[Union[type[fields.Field], type[related.RelatedField], type[reverse_related.ForeignObjectRel]], type] input_field_type_map
}
class relay_field_type_map {
+dict[Union[type[fields.Field], type[related.RelatedField], type[reverse_related.ForeignObjectRel]], type] relay_field_type_map
}
class relay_input_field_type_map {
+dict[Union[type[fields.Field], type[related.RelatedField], type[reverse_related.ForeignObjectRel]], type] relay_input_field_type_map
}
class DjangoPermissionExtension {
+list[Location] SCHEMA_DIRECTIVE_LOCATIONS
}
class HasPerm {
+Union[list[str], str] perms
+tuple[PermDefinition, ...] perms
}
class AutoDirective {
+list[PermDefinition] permissions
}
class DjangoRegisterMutation {
+type["AbstractBaseUser"] model
}
class DictTree {
+dict[str, "DictTree"] DictTree
}
class _BaseFactory {
+list[_T] create_batch
}
class Query {
+list[Fruit] fruits
+list[Color] colors
}
class Mutation {
+list[Fruit] create_fruits
+list[Fruit] update_fruits
+list[Fruit] delete_fruits
+list[Color] create_colors
+list[Color] update_colors
+list[Color] delete_colors
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
- Coverage 88.93% 88.71% -0.22%
==========================================
Files 41 41
Lines 3596 3606 +10
==========================================
+ Hits 3198 3199 +1
- Misses 398 407 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bellini666 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add official support for Python 3.13 and remove support for Python 3.8. Refactor type annotations to use the new list and type syntax introduced in Python 3.9. Update CI configuration to reflect these changes.
New Features:
Enhancements:
CI: