Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-level nested create/update with model full_clean() #659

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support multi-level nested create/update with model full_clean() #659

wants to merge 7 commits into from

Commits on Dec 10, 2024

  1. Add support for nested creation/update in mutations. This also has th… 

    …e benefit of consistently calling `full_clean()` before creating related instances.

This does remove the `get_or_create()` calls and instead uses `create` only. The expectation here is that `key_attr` could and should be used to indicate what field should be used as the unique identifier, and not something hard coded that could have unintended side effects when creating related instances that don't have unique constraints and expect new instances to always be created.
    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    58d9df2 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    21e86d0 View commit details
    Browse the repository at this point in the history

  3. First test (heavily based on one from an existing PR)

    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    7fbd723 View commit details
    Browse the repository at this point in the history

  4. Update new test with m2m creation/use

    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    05412b8 View commit details
    Browse the repository at this point in the history

  5. Add test for nested creation when creating a new resource

    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    e16d70e View commit details
    Browse the repository at this point in the history

  6. Add test for full_clean being called when performing nested creation … 

    …or resources
    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    ecee136 View commit details
    Browse the repository at this point in the history

  7. Remove unecessary @transaction.atomic() call

    @philipstarkey
    philipstarkey committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    b73c0fb View commit details
    Browse the repository at this point in the history