Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydantic v2 test error ConstrainedList removed in v2 #3034

Conversation

tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Aug 14, 2023

  • Mark pydantic constrained list test with need_pydantic_v1 since it is removed in pydantic V2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

- Mark pydantic constrained list test with need_pydantic_v1 since it is removed in pydantic V2
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #3034 (454e38c) into main (5c2105b) will increase coverage by 0.14%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3034      +/-   ##
==========================================
+ Coverage   96.39%   96.54%   +0.14%     
==========================================
  Files         468      468              
  Lines       29173    29176       +3     
  Branches     3589     3589              
==========================================
+ Hits        28122    28168      +46     
+ Misses        863      827      -36     
+ Partials      188      181       -7     

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 14, 2023

CodSpeed Performance Report

Merging #3034 will not alter performance

Comparing tjeerddie:fix-pydantic-test-constrained-list (454e38c) with main (5c2105b)

Summary

✅ 12 untouched benchmarks

@patrick91 patrick91 merged commit 28dfb2e into strawberry-graphql:main Aug 14, 2023
43 of 49 checks passed
etripier pushed a commit to Greenbax/strawberry that referenced this pull request Oct 25, 2023
…graphql#3034)

- Mark pydantic constrained list test with need_pydantic_v1 since it is removed in pydantic V2

Co-authored-by: Tjeerd.Verschragen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants