Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "babel-eslint" parser to "@babel/eslint-parser" #326

Open
6 tasks done
DataHearth opened this issue Oct 29, 2021 · 1 comment · May be fixed by #327
Open
6 tasks done

Update "babel-eslint" parser to "@babel/eslint-parser" #326

DataHearth opened this issue Oct 29, 2021 · 1 comment · May be fixed by #327

Comments

@DataHearth
Copy link
Contributor

DataHearth commented Oct 29, 2021

As said on the NPM page and when installing the dependency, babel-eslint is deprecated in favour to @babel/eslint-parser. I'll be bring updates and maintenance to it and remove the warning in command line.

TO-DO:

  • install @babel/eslint-parser as development dependency
  • replace babel-parser by @babel/eslint-parser inside the parser field in .eslintrc.json
  • replace eslint-plugin-babel by @babel/eslint-plugin development dependency
  • replace babel by @babel inside plugins array in .eslintrc.json
  • update all rules naming
  • check everything is working as intended

CLI OUTPUT:

npm WARN deprecated [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.

Links:

@DataHearth
Copy link
Contributor Author

I've also spotted some "issue" inside the .eslintrc.json configuration file. Here are the duplicates:

  • import/no-commonjs => 2 and off
  • strict => [2, "never"] and off
  • import/unambiguous => 1 and off
  • promise/prefer-await-to-then => 1 and off

Is there a reason why they're duplicates ? Should it be added to the issue while we're at it ^^ ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant