fix names

Author: Jeffrey Koehler

redisconsistent/metrics.go

@@ -125,10 +125,10 @@ var RectifyWorkError = promauto.NewCounterVec(prometheus.CounterOpts{
 	Name:      "error_rectify_work",
 	Help:      "An error was encountered attempting to rectify the worker's work that needs to be processed/completed.",
 }, []string{"divider"})
-var RemoveWorkFromDividerError = promauto.NewCounterVec(prometheus.CounterOpts{
+var RemoveWorkFromDividerStorageError = promauto.NewCounterVec(prometheus.CounterOpts{
 	Namespace: "streemtech",
 	Subsystem: "redis_work_divider",
-	Name:      "error_remove_work_from_divider",
+	Name:      "error_remove_work_from_divider_storage",
 	Help:      "An error was encountered attempting to remove work from the stored work that needs to be done in redis",
 }, []string{"divider"})
 var StartWorkExternalError = promauto.NewCounterVec(prometheus.CounterOpts{
@@ -216,7 +216,7 @@ func InitMetrics(name string) {
 		PublishAddWorkToDividerError.MetricVec,
 		PublishRemoveWorkFromDividerError.MetricVec,
 		RectifyWorkError.MetricVec,
-		RemoveWorkFromDividerError.MetricVec,
+		RemoveWorkFromDividerStorageError.MetricVec,
 		StartWorkExternalError.MetricVec,
 		StopWorkExternalError.MetricVec,
 		WorkFetcherError.MetricVec,

redisconsistent/redis.go

@@ -142,7 +142,7 @@ func (d *dividerWorker) StopProcessing(ctx context.Context, works ...string) err
 	start := time.Now()
 	err := d.storage.RemoveWorkFromDividedWork(ctx, works)
 	if err != nil {
-		ObserveInc(RemoveWorkFromDividerError, d.conf.metricsName, 1)
+		ObserveInc(RemoveWorkFromDividerStorageError, d.conf.metricsName, 1)
 		return errors.Wrap(err, "failed to Remove Work From Divided Work")
 	}
 	for _, work := range works {
@@ -334,7 +334,7 @@ func (d *dividerWorker) masterUpdateRequiredWorkFunc() {
 	err = d.storage.RemoveWorkFromDividedWork(d.ctx, remove)
 	if err != nil {
 		d.conf.logger(d.ctx).Error("failed to remove the old work", slog.String("err.error", err.Error()), slog.String("divider.id", d.conf.instanceID))
-		ObserveInc(RemoveWorkFromDividerError, d.conf.metricsName, 1)
+		ObserveInc(RemoveWorkFromDividerStorageError, d.conf.metricsName, 1)
 		return
 	}