Skip to content

Commit bc404b2

Browse files
committed
enable OH and wheelchair for more craft=
added some walk-in craft types into these quests (triggered by mapping carft=window_construction in Places overlay and not being asked OH quest, went looking what else is in iD presets and missing here) some other craft values where I was less sure: craft = agricultural_engines craft = basket_maker craft = beekeeper craft = blacksmith craft = boatbuilder craft = builder craft = carpet_layer craft = caterer craft = chimney_sweeper craft = cleaning craft = confectionery craft = electrician craft = floorer craft = gardener craft = glaziery craft = handicraft craft = hvac craft = insulation craft = joiner craft = metal_construction craft = painter craft = parquet_layer craft = photographic_laboratory craft = plasterer craft = plumber craft = pottery craft = rigger craft = roofer craft = saddler craft = scaffolder craft = sculptor craft = signmaker craft = tiler craft = tinsmith craft = upholsterer these values were found with a following Python script: import taginfo craft_values_supported_by_sc = ["carpenter", "shoemaker", "tailor", "photographer", "dressmaker", "electronics_repair", "key_cutter", "stonemason", "jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker", "locksmith", "bookbinder", "window_construction", # added now ] key = "craft" project = "id_editor" for value, entry in taginfo.analysis.get_tagging_supported_by_id_except_deprecations()[key].items(): if(value == None): continue if value in ["brewery", "distillery", "winery", "oil_mill", "grinding_mill", "sawmill"]: # seem less likely to have walk-in visitors continue if(value in craft_values_supported_by_sc): continue print(key, "=", value) #print(entry)
1 parent a77e02a commit bc404b2

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ class AddOpeningHours(
8787
"craft" to arrayOf(
8888
// common
8989
"carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
90-
"electronics_repair", "key_cutter", "stonemason"
90+
"electronics_repair", "key_cutter", "stonemason", "bookbinder",
91+
"jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker",
92+
"locksmith", "window_construction",
9193
),
9294
"healthcare" to arrayOf(
9395
// common

‎app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ class AddWheelchairAccessBusiness : OsmFilterQuestType<WheelchairAccess>() {
8989
"craft" to arrayOf(
9090
// common
9191
"carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
92-
"electronics_repair", "key_cutter", "stonemason",
92+
"electronics_repair", "key_cutter", "stonemason", "bookbinder",
93+
"jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker",
94+
"locksmith", "window_construction",
9395

9496
// name & wheelchair
9597
"winery"

0 commit comments

Comments
 (0)