Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the crosshair in the screen center #5760

Open
martinrieder opened this issue Jul 22, 2024 · 4 comments
Open

Place the crosshair in the screen center #5760

martinrieder opened this issue Jul 22, 2024 · 4 comments

Comments

@martinrieder
Copy link

martinrieder commented Jul 22, 2024

Use case

While doing surveys, I prefer the screen tracking my current position. When tapping the "current location" button twice, the icon turns orange and it pins to the screen center. The issue is that the crosshair is placed at a different screen location. Two scenarios that I have experienced:

  1. When I want to place a POI at my current location, I need to scroll the screen, in order to move the crosshair. The location tracking is turned off and I have to reactivate this after the object has been placed. I understand that in most situations, you would place an object that you see ahead of you. IMO this over-complicates placement of small things like street lamps, recycle bins, signs etc.
  2. I want to place a note by taking a picture at my current location. This also requires scrolling to my location and long-tapping the screen. It has happened to me a few times that the note was placed at the wrong location because I rotated the phone to take the picture, but similar behavior has been discussed in Notes may be positioned at places where the user did not intend them to be placed #5581 already. It is still possible to manually correct the location if you pay attention before submitting the note, which is why I am not intending to reopen the issue or to file another bug report.

Proposed Solution

Simply place the crosshair at the center of the screen, so it matches my current location when tracking is locked-in.
Optionally, the preferred crosshair location may be selected from the settings menu.

I could also imagine some advanced behavior that would make the crosshair "follow" my current location at a fixed distance. Pinning it to the screen center seems like the lower hanging fruit, though.

Anyways, this would be a huge UX improvement by not having to always reactivate the location tracking. Additionally, it would avoid any issues about unintended placement of notes and objects when the screen is rotated.

@Nick-Tallguy
Copy link
Contributor

Definitely agree on this. The first item I created was a bench which I had to move when I got home, as I had accidentally placed it in the middle of a car park about 30 meters from where I intended.
Also, the distance away of the cross hairs is difficult to judge with no scale on the screen.
Now I always walk up to the object and then adjust the screen to put the cross hairs on me before creating an object.

@westnordost
Copy link
Member

I am aware of this issue. It is a bit difficult with tangram-es, my hope is that it will be easier with MapLibre. I actually did (attempt to) change something here, but not sure if I succeeded. Will need to check. (Assigning to me for checking)

Ideal would be if the user's location and also the crosshair would be in the center of the screen, and when a bottom sheet for quest or overlay input appears, the mentioned center is recalculated to be in the center of the visible map area above the bottom sheet. I.e. it shifts up

@westnordost westnordost self-assigned this Jul 23, 2024
@westnordost
Copy link
Member

Checked. It looks like it is the same in MapLibre. I remember I tried though. I will defer this until after migration to Compose. In the meantime, others are of course invited to give it a try.

@goldfndr
Copy link
Contributor

To address this and #6004, I suggest centering the crosshair wherever the blue dot's center would default to on-screen while tracking.

I admittedly don't know the strategy behind the rough UI from #2461 having the crosshair in the upper half.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants