Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished upload closes open quest dialog #5916

Open
HolgerJeromin opened this issue Sep 21, 2024 · 2 comments
Open

Finished upload closes open quest dialog #5916

HolgerJeromin opened this issue Sep 21, 2024 · 2 comments
Labels

Comments

@HolgerJeromin
Copy link
Contributor

How to Reproduce

Open things overlay.
Add hydrant
Be fast enough to open first quest on this new element while is just uploading. Probably this is location quest.
After upload of the element creation the quest is closed.

I am pretty sure that this is the case even with the second quest (diameter), too.
So this is IMHO a generic sync issue and no specific "the node id changes from negative temp id to a positive real id".

Expected Behavior

The open quest should be still open.

Versions affected

The same since a few month. But also with v59:

@HolgerJeromin HolgerJeromin changed the title Finished upload closes next quest Finished upload closes open quest dialog Sep 21, 2024
@westnordost
Copy link
Member

This happens on follow-up quests of newly created elements because the OsmQuestKey in the questKey fiel in AbstractQuestForm isn't updated/replaced when the id of an element changed. (The id of an element changes on upload from some negative number to a number assigned by the OSM API).

@westnordost
Copy link
Member

See also #5809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants