Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rendering on "highway=pedestrian" ways #1

Closed
wants to merge 1 commit into from

Conversation

mnalis
Copy link
Owner

@mnalis mnalis commented Oct 11, 2022

Closes: streetcomplete#119

as found by @Helium314 in streetcomplete#119 (comment) and validated by @matkoniecz in streetcomplete#119 (comment), removing those lines fixes the problematic rendering of on highway=pedestrian ways, without making areas problematic.

test .apk with manually modified app/src/main/assets/map_theme/jawg/layers/land.yaml compiles and works fine.

Here is example of both way and area for highway=pedestrian, before and after:

small_Screenshot_20221011_222154_de westnordost streetcomplete small_Screenshot_20221011_220051_de westnordost streetcomplete mn debug2

Confusing line in the middle of the way is fixed (right middle of the screenshot), while area on the left side is not really negatively affected.

@matkoniecz
Copy link

one of results is no longer displaying minor inner borders of pedestrian areas, like https://www.openstreetmap.org/way/304011759

(transparency difference is an unrelated issue)
screen11

Copy link

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still, overall this is improvements and see no better way to fix it

@mnalis
Copy link
Owner Author

mnalis commented Aug 27, 2024

Anyway, it seems that StreetComplete MapLibre v59.0-alpha1 version fixes those pedestrian ways, so this is not needed anymore. e.g. https://www.openstreetmap.org/way/222942946:

small_Screenshot_20240827_042011_SCEE ▶️ small_Screenshot_20240827_042018_StreetComplete

@mnalis mnalis closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

confusing style for highway=pedestrian
2 participants