Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unmaintained dependency go-difflib #736

Closed
Crevil opened this issue Mar 7, 2019 · 3 comments
Closed

Remove unmaintained dependency go-difflib #736

Crevil opened this issue Mar 7, 2019 · 3 comments
Labels
dependencies Pull requests that update a dependency file rejected/duplicate

Comments

@Crevil
Copy link

Crevil commented Mar 7, 2019

The package github.com/pmezard/go-difflib is as of this commit no longer maintained: pmezard/go-difflib@1ef1646

Maybe we could move the used functionality into this repo and stop depending on the difflib package all together?

The functions used are difflib.GetUnifiedDiffString() and difflib.SplitLines().
@kkaushy
Copy link

kkaushy commented Mar 30, 2022

Is there any update on this.

@obsti8383 obsti8383 mentioned this issue Jun 5, 2022
Closed
@dolmen
Copy link
Collaborator

dolmen commented Nov 19, 2023

Who will maintain that imported code?

What are the issues in difflib code that need fixes?

So far, as a maintainer, I don't see any advantages compared to the status quo.

@dolmen dolmen added rejected/duplicate dependencies Pull requests that update a dependency file labels Nov 19, 2023
@dolmen
Copy link
Collaborator

dolmen commented Nov 19, 2023

Duplicate of #1187.

@dolmen dolmen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2023
This was referenced Feb 17, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file rejected/duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

integrate github.com/pmezard/go-difflib obsti8383/testify
3 participants
@dolmen @kkaushy @Crevil