-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker fixes - new compose (podman support also) #1051
Comments
@hozza thanks for opening this! A PR would be very welcome, as my Docker experience is extremely limited. I end up running in circles every time I try to dig in. We've also been chatting about it in #1050. Maybe @guidopetri will have opinions on this as well. |
I'll agree on all points above :) I'm not super confident on the PUID/PGID nor on the podman side of things (I don't run it myself) but migrating to alpine base image sounds good, and using an env file also sounds great (and I do this myself, actually, heh). One potential addition here is to make the port binding localhost only ( I also agree that the different links (swanson, mockdeep, stringer-rss) are a bit confusing. I'm partial to keeping everything under |
I think the |
Ok great stuff. So it looks like there's a few work streams here:
|
It's nothing fancy. I have a bunch of other services in the same compose file, so here's the section for stringer: stringer:
build: https://github.com/guidopetri/stringer.git#rails_env
container_name: stringer
restart: always
ports:
- "127.0.0.1:5000:5000"
depends_on:
- postgres
env_file:
- ${HOME}/.env_files/.stringer_env And the env file is of the format:
For the Docker image building in CI, I was going to work on adding it to CI + making it build all three of amd64/arm/arm64. If you're more familiar with CircleCI though, feel free to take that on :) I have #1053 open to make the Dockerfile accept other architectures, |
@guidopetri thanks for the updates! I fixed one bundler issue, but now it's giving an error while installing gems:
I don't have a clear sense of what to do about that. Any ideas? |
I opened an issue on the CircleCI Docker orb. |
Sorry for the delay here, I try not to do a lot of open source during the week :) Unfortunately I have also got no idea where that error is coming from. I can investigate a bit more closely this weekend or next perhaps? If the faulty build is blocking |
@guidopetri no hurry, It's not blocking merges or anything, though it would be nice to have a passing |
This might be a bundler problem, not a CircleCI problem: rubygems/rubygems#4353 , rubygems/bundler#4367 maybe we need to set the number of threads to 1? I'm not sure how to do that, though. |
@mockdeep did you end up opening a support request with CircleCI? I can try and carve out some time to find a solution if not. |
@guidopetri so far I've opened an issue on the orb, as well as opening a discussion on their forum, but no response on either. I was starting to think maybe we could move to using Github Actions for the docker image instead. It would be nice to have a build step for each PR, and only publish on |
Ok, I can give that a shot. Would you want to remove the circleCI testing or keep both circleCI and gh actions? |
@guidopetri great thanks! I think for now we can focus on getting the docker image on GA and leave the tests on CircleCI. |
Potentially helping docker related issues #741 and #523
Repo Linking
There are several links under different usernames/repos. I'm not sure how mantainers want to manaage this but it would help with docker issues if there could be one official repo that's linked everywhere and also published on on Docker Hub under this name also.
Compose Tweaks
Fixes and improvement suggestion plus support rootless containers, (podman, podman-compose), if you're happy with these suggestions I'll submit PR. These tweaks make the docker docs accurate also.
Container suggestions
The text was updated successfully, but these errors were encountered: