Update kotlin to 2.3.10. (#12373)

Author: jaynewstrom-stripe

.github/workflows/codeql.yml

@@ -45,8 +45,8 @@ jobs:
         include:
         - language: actions
           build-mode: none
-        - language: java-kotlin
-          build-mode: autobuild
+#        - language: java-kotlin
+#          build-mode: autobuild
         - language: javascript-typescript
           build-mode: none
         - language: python

3ds2playground/dependencies/dependencies.txt

@@ -192,29 +192,29 @@ class ChallengeResponseDataTest {
         assertNotNull(cresData.issuerImage)
         assertEquals(
             "http://acs.com/medium_image.png",
-            cresData.issuerImage?.mediumUrl
+            cresData.issuerImage.mediumUrl
         )
         assertEquals(
             "http://acs.com/high_image.png",
-            cresData.issuerImage?.highUrl
+            cresData.issuerImage.highUrl
         )
         assertEquals(
             "http://acs.com/extraHigh_image.png",
-            cresData.issuerImage?.extraHighUrl
+            cresData.issuerImage.extraHighUrl
         )
 
         assertNotNull(cresData.paymentSystemImage)
         assertEquals(
             "http://ds.com/medium_image.png",
-            cresData.paymentSystemImage?.mediumUrl
+            cresData.paymentSystemImage.mediumUrl
         )
         assertEquals(
             "http://ds.com/high_image.png",
-            cresData.paymentSystemImage?.highUrl
+            cresData.paymentSystemImage.highUrl
         )
         assertEquals(
             "http://ds.com/extraHigh_image.png",
-            cresData.paymentSystemImage?.extraHighUrl
+            cresData.paymentSystemImage.extraHighUrl
         )
 
         assertEquals("Click here to open Your Bank App", cresData.oobAppLabel)
@@ -254,33 +254,33 @@ class ChallengeResponseDataTest {
         assertNotNull(cresData.paymentSystemImage)
         assertEquals(
             "http://ds.com/medium_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_LOW)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_LOW)
         )
         assertEquals(
             "http://ds.com/medium_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_MEDIUM)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_MEDIUM)
         )
 
         assertEquals(
             "http://ds.com/high_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_MEDIUM + 1)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_MEDIUM + 1)
         )
         assertEquals(
             "http://ds.com/high_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_HIGH)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_HIGH)
         )
         assertEquals(
             "http://ds.com/high_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_XHIGH - 1)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_XHIGH - 1)
         )
 
         assertEquals(
             "http://ds.com/extraHigh_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_XHIGH)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_XHIGH)
         )
         assertEquals(
             "http://ds.com/extraHigh_image.png",
-            cresData.paymentSystemImage?.getUrlForDensity(DisplayMetrics.DENSITY_XXHIGH)
+            cresData.paymentSystemImage.getUrlForDensity(DisplayMetrics.DENSITY_XXHIGH)
         )
     }
 
@@ -321,14 +321,14 @@ class ChallengeResponseDataTest {
 
         assertNotNull(cresData.acsHtml)
         assertTrue(
-            true == cresData.acsHtml?.contains(
+            cresData.acsHtml.contains(
                 "<title>3DS - One-Time Passcode - PA</title>"
             )
         )
 
         assertNotNull(cresData.acsHtmlRefresh)
         assertTrue(
-            true == cresData.acsHtmlRefresh?.contains(
+            cresData.acsHtmlRefresh.contains(
                 "<p>Tap continue once you have verified this payment.</p>"
             )
         )

3ds2sdk/dependencies/dependencies.txt

@@ -229,15 +229,15 @@ class ChallengeFragmentTest {
             assertFalse(challengeZoneView.infoTextView.isShown)
             assertFalse(challengeZoneView.submitButton.isShown)
 
-            assertNotNull(fragment.challengeZoneWebView?.onClickListener)
+            assertNotNull(fragment.challengeZoneWebView.onClickListener)
         }
     }
 
     @Test
     fun refreshUi_htmlOOB_acsRefreshHtmlDisplayed() {
         createFragment(cres = CRES_HTML_DATA) { fragment ->
             fragment.refreshUi()
-            assertThat(fragment.challengeZoneWebView?.webView)
+            assertThat(fragment.challengeZoneWebView.webView)
                 .isNotNull()
         }
     }

3ds2sdk/src/test/kotlin/com/stripe/android/stripe3ds2/transactions/ChallengeResponseDataTest.kt

@@ -4,6 +4,13 @@
 
 ## 22.8.1 - 2026-02-17
 
+Dependencies updated in [12373](https://github.com/stripe/stripe-android/pull/12373):
+- Bumped Kotlin from 2.1.10 to 2.3.10.
+- Bumped Kotlin Coroutines from 1.10.1 to 1.10.2.
+- Bumped Kotlin Serialization from 1.8.0 to 1.10.0.
+- Bumped Android Gradle Plugin from 8.13.1 to 8.13.2.
+- Bumped Poko from 0.18.2 to 0.21.1.
+
 ### Identity
 * [Added] More live feedback during document capture.
 * [Added] Added best frame detector to improve document capture quality.

3ds2sdk/src/test/kotlin/com/stripe/android/stripe3ds2/views/ChallengeFragmentTest.kt

@@ -15,6 +15,22 @@ detekt {
     }
 }
 
+def detektIgnoreFile = file('.detektignore')
+if (detektIgnoreFile.exists()) {
+    def detektIgnorePatterns = []
+    detektIgnoreFile.eachLine { line ->
+        line = line.trim()
+        if (!line.isEmpty() && !line.startsWith('#')) {
+            detektIgnorePatterns.add(line)
+        }
+    }
+    afterEvaluate {
+        tasks.matching { it.name.startsWith('detekt') && it instanceof org.gradle.api.tasks.SourceTask }.configureEach {
+            detektIgnorePatterns.each { pattern -> exclude(pattern) }
+        }
+    }
+}
+
 dependencies {
     detektPlugins "io.gitlab.arturbosch.detekt:detekt-formatting:$versions.detekt"
     detektPlugins "io.gitlab.arturbosch.detekt:detekt-cli:$versions.detekt"

CHANGELOG.md

@@ -6,16 +6,29 @@ dependencies {
     ktlint("com.pinterest.ktlint:ktlint-cli:${versions.ktlint}")
 }
 
+def ktlintIgnoreArgs = []
+def ktlintIgnoreFile = file('.ktlintignore')
+if (ktlintIgnoreFile.exists()) {
+    ktlintIgnoreFile.eachLine { line ->
+        line = line.trim()
+        if (!line.isEmpty() && !line.startsWith('#')) {
+            ktlintIgnoreArgs.add("!${line}")
+        }
+    }
+}
+
 task ktlint(type: JavaExec, group: "verification") {
     description = "Check Kotlin code style."
     mainClass = "com.pinterest.ktlint.Main"
     classpath = configurations.ktlint
     args "src/**/*.kt"
+    args ktlintIgnoreArgs
 }
 
 task ktlintFormat(type: JavaExec, group: "formatting") {
     description = "Fix Kotlin code style deviations."
     mainClass = "com.pinterest.ktlint.Main"
     classpath = configurations.ktlint
     args "-F", "src/**/*.kt"
+    args ktlintIgnoreArgs
 }

build-configuration/detekt.gradle

@@ -29,9 +29,9 @@ buildscript {
 plugins {
     id 'io.github.gradle-nexus.publish-plugin' version '1.3.0'
     id 'io.codearte.nexus-staging' version '0.30.0'
-    id 'com.google.devtools.ksp' version '2.1.10-1.0.30' apply false
-    id 'dev.drewhamilton.poko' version '0.18.2' apply false
-    id 'org.jetbrains.kotlin.jvm' version '2.1.10' apply false
+    id 'com.google.devtools.ksp' version '2.3.6' apply false
+    id 'dev.drewhamilton.poko' version '0.21.1' apply false
+    id 'org.jetbrains.kotlin.jvm' version '2.3.10' apply false
     id 'com.emergetools.android' version '4.3.0' apply false
     id 'com.google.dagger.hilt.android' version '2.58' apply false
 }